connectors-ci: discard the use of /test

[alafanechere]

Tell us about the problem you're trying to solve

The connectors-ci test-connectors command running in the CI is made to replace the use of the /test slash command from PR comments.
Once we're confident about the stability of this workflow we should remove the /test command and remove documentation about its usage.

This future legacy workflow is declared here:
https://github.com/airbytehq/airbyte/blob/master/.github/workflows/test-command.yml#L1

[evantahler]

This is the best issue.

[alafanechere]

Rollout plan:

1. Make sure we have stable and consistent results between /test and Dagger pipelines (connectors-ci: compare legacy and dagger results for nightly builds #25053)
2. Expose PR metadata to dagger test pipeline to: check the current PR is ready for review (Run connectors tests only when PR is ready for review #25279), we can post on deprecation message to PR (#25431), PR url can be shared in test reports (connectors-ci: add PR ID and CDK version to test reports #24322).
3. Make the Connectors CI check required to merge connector PR (connectors-ci: make the "Connectors CI" check required to merge connector PR #23976) (connectors-ci: when nothing was run the commit check should be set to success / skipped #25183)

Questions

1. As /publish is also running tests "the old" shall we wait for /publish to be deprecated too (publish on master in production)?

[evantahler]

Grooming:

Notes

• we should depreciate /publish first, and leave both /test and ci-test around while we ensure they both match
• --pre-release will still exist with a github action, so you can choose any branch + GH action to publish a pre-release image. You can also do that locally!
• depreciation message on /test (we can re-use the comment posting logic to say "don't use this any more"); only if used on a PR. /test still works until stories below are complete. depreciation doesn't mean delete it.
  • But... nightly builds also use /test

New Stories:

• CI needs to gain flag to use local CDK
• CI needs to gain flag to use choose CDK version