Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source MSSQL: Connector provides wrong values for some datatypes #4270

Closed
Tracked by #6994
etsybaev opened this issue Jun 22, 2021 · 0 comments · Fixed by #7748
Closed
Tracked by #6994

Source MSSQL: Connector provides wrong values for some datatypes #4270

etsybaev opened this issue Jun 22, 2021 · 0 comments · Fixed by #7748
Assignees

Comments

@etsybaev
Copy link
Contributor

etsybaev commented Jun 22, 2021

Found by comprehensive tests #3562

Expected Behavior

A connector should transform source data into an Airbyte datatype without value/meaning losses.

Current Behavior

General source implementation:

  • 'binary', 'varbinary'. Returns binary value instead of actual value.

Steps to Reproduce

Short way:

  1. Checkout master branch
  2. Go to MssqlSourceComprehensiveTest.java and find tests with appropriate types. Use example values from comment to insert to addInsertValues and addExpectedValues
  3. Run the test.
  4. 💣
    NOTES: To REMEMBER while fixing this bug: Most of the cases would need to be corrected at JdbcUtils, but this is based class that is used by all others JDBC DBs, i.e. all other JDBC DBs will be affected

Severity of the bug for you

High

Airbyte Version

0.24.7-alpha

Connector Version

0.3.7

Origin ticket: #3794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants