-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🔧 Allow overwriting experiments and features during development #20843
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
49c4982
Allow overwriting experiments via special file
timroes 806b7a7
Allow feature overwriting via .features.dev
timroes 0fbf093
Merge branch 'master' into tim/dev-overwrites
timroes 5a1ce1a
Adjust to discussion
timroes baba56a
Merge branch 'master' into tim/dev-overwrites
timroes 9cde982
Merge branch 'master' into tim/dev-overwrites
timroes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
const fs = require("fs"); | ||
const path = require("path"); | ||
|
||
const dotenv = require("dotenv"); | ||
|
||
function parseFromString(value) { | ||
if (value === "true") { | ||
return true; | ||
} | ||
if (value === "false") { | ||
return false; | ||
} | ||
if (value.startsWith("[") || value.startsWith("{")) { | ||
return JSON.parse(value); | ||
} | ||
|
||
return value; | ||
} | ||
|
||
const EXPERIMENTS_FILE = path.resolve(__dirname, "../.experiments.dev"); | ||
|
||
if (fs.existsSync(EXPERIMENTS_FILE)) { | ||
console.log("\nOverwriting experiments from .experiments.dev ..."); | ||
const rawOverwrites = dotenv.parse(fs.readFileSync(EXPERIMENTS_FILE)); | ||
const overwrites = Object.fromEntries( | ||
Object.entries(rawOverwrites).map(([key, value]) => { | ||
return [key, parseFromString(value)]; | ||
}) | ||
); | ||
|
||
if (Object.keys(overwrites).length) { | ||
console.log(`Overwriting experiments with the following values:\n\n${JSON.stringify(overwrites, null, 2)}`); | ||
process.env.REACT_APP_EXPERIMENT_OVERWRITES = JSON.stringify(overwrites); | ||
} | ||
} | ||
|
||
const FEATURES_FILE = path.resolve(__dirname, "../.features.dev"); | ||
|
||
if (fs.existsSync(FEATURES_FILE)) { | ||
console.log("\nOverwriting feature states from .features.dev ..."); | ||
const overwrites = dotenv.parse(fs.readFileSync(FEATURES_FILE)); | ||
Object.entries(overwrites).forEach(([key, value]) => { | ||
console.log(`Overwrite feature ${key} with value ${value}`); | ||
process.env[`REACT_APP_FEATURE_${key}`] = value; | ||
}); | ||
} | ||
timroes marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Not sure why this was ignored, since it was also checked in (and should be). So I removed it from the .gitignore file.