Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Allow overwriting experiments and features during development #20843

Merged
merged 6 commits into from
Jan 17, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions airbyte-webapp/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,12 @@ yarn-error.log*
/.idea

.npmrc
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Not sure why this was ignored, since it was also checked in (and should be). So I removed it from the .gitignore file.


# Environment overwrites
.env.development
.env.production
.experiments.dev
.features.dev
timroes marked this conversation as resolved.
Show resolved Hide resolved

storybook-static/

Expand Down
4 changes: 2 additions & 2 deletions airbyte-webapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"scripts": {
"prepare": "cd .. && husky install airbyte-webapp/.husky",
"prestart": "npm run generate-client",
"start": "craco start",
"start": "node -r ./scripts/dev-overwrites.js ./node_modules/.bin/craco start",
"prestart:cloud": "npm run generate-client",
"start:cloud": "AB_ENV=${AB_ENV-frontend-dev} node -r ./scripts/environment.js ./node_modules/.bin/craco start",
"start:cloud": "AB_ENV=${AB_ENV-frontend-dev} node -r ./scripts/environment.js -r ./scripts/dev-overwrites.js ./node_modules/.bin/craco start",
"prebuild": "npm run generate-client",
"build": "BUILD_PATH='./build/app' craco build",
"pretest": "npm run generate-client",
Expand Down
46 changes: 46 additions & 0 deletions airbyte-webapp/scripts/dev-overwrites.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
const fs = require("fs");
const path = require("path");

const dotenv = require("dotenv");

function parseFromString(value) {
if (value === "true") {
return true;
}
if (value === "false") {
return false;
}
if (value.startsWith("[") || value.startsWith("{")) {
return JSON.parse(value);
}

return value;
}

const EXPERIMENTS_FILE = path.resolve(__dirname, "../.experiments.dev");

if (fs.existsSync(EXPERIMENTS_FILE)) {
console.log("\nOverwriting experiments from .experiments.dev ...");
const rawOverwrites = dotenv.parse(fs.readFileSync(EXPERIMENTS_FILE));
const overwrites = Object.fromEntries(
Object.entries(rawOverwrites).map(([key, value]) => {
return [key, parseFromString(value)];
})
);

if (Object.keys(overwrites).length) {
console.log(`Overwriting experiments with the following values:\n\n${JSON.stringify(overwrites, null, 2)}`);
process.env.REACT_APP_EXPERIMENT_OVERWRITES = JSON.stringify(overwrites);
}
}

const FEATURES_FILE = path.resolve(__dirname, "../.features.dev");

if (fs.existsSync(FEATURES_FILE)) {
console.log("\nOverwriting feature states from .features.dev ...");
const overwrites = dotenv.parse(fs.readFileSync(FEATURES_FILE));
Object.entries(overwrites).forEach(([key, value]) => {
console.log(`Overwrite feature ${key} with value ${value}`);
process.env[`REACT_APP_FEATURE_${key}`] = value;
});
}
timroes marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import { createContext, useContext, useMemo } from "react";
import { useObservable } from "react-use";
import { EMPTY, Observable } from "rxjs";

const devOverwrites = process.env.REACT_APP_EXPERIMENT_OVERWRITES
? (JSON.parse(process.env.REACT_APP_EXPERIMENT_OVERWRITES) as Record<string, unknown>)
: {};

const experimentContext = createContext<ExperimentService | null>(null);

/**
Expand All @@ -15,7 +19,7 @@ export interface ExperimentService {
getExperimentChanges$<K extends keyof Experiments>(key: K): Observable<Experiments[K]>;
}

export function useExperiment<K extends keyof Experiments>(key: K, defaultValue: Experiments[K]): Experiments[K] {
function useExperimentHook<K extends keyof Experiments>(key: K, defaultValue: Experiments[K]): Experiments[K] {
const experimentService = useContext(experimentContext);
// Get the observable for the changes of the experiment or an empty (never emitting) observable in case the
// experiment service doesn't exist (e.g. we're running in OSS or it failed to initialize)
Expand All @@ -25,4 +29,17 @@ export function useExperiment<K extends keyof Experiments>(key: K, defaultValue:
return useObservable(onChanges$, experimentService?.getExperiment(key, defaultValue) ?? defaultValue);
}

function useExperimentWithOverwrites<K extends keyof Experiments>(
key: K,
defaultValue: Experiments[K]
): Experiments[K] {
// Load the regular experiments value via the prod hook
const value = useExperimentHook(key, defaultValue);
// Use the overwrite value if it's available, otherwise the proper value
return key in devOverwrites ? (devOverwrites[key] as Experiments[K]) : value;
}

// Allow overwriting values via the .experiments.dev file (and thus the REACT_APP_EXPERIMENT_OVERWRITES env variable) only during development
export const useExperiment = process.env.NODE_ENV === "development" ? useExperimentWithOverwrites : useExperimentHook;

export const ExperimentProvider = experimentContext.Provider;