-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: add dagger run url #28947
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0c6ad4e
add dagger run url
pedroslopez 28f5d6b
version bump
pedroslopez 4b3cfec
making a change so tests are auto triggered
pedroslopez a406551
fix dagger cloud url
pedroslopez cd757c9
fix no args
pedroslopez cbd3cdf
naming / formatting
pedroslopez 9feaba9
try nowrap
pedroslopez cf08ebb
try soft_wrap
pedroslopez 02536c4
just log it
pedroslopez e54b090
move log
pedroslopez 3929591
revert fake change
pedroslopez 4854ee3
rename
pedroslopez 9ab0f68
nits
pedroslopez 46eaedb
Update airbyte-ci/connectors/pipelines/pipelines/tests/templates/test…
pedroslopez 5966fd9
Update airbyte-ci/connectors/pipelines/pipelines/contexts.py
pedroslopez b3a7496
Merge branch 'master' into pedroslopez/dagger-cloud-run-url
pedroslopez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,7 +89,7 @@ def check_dagger_cli_install() -> str: | |
def main(): | ||
os.environ[DAGGER_CLOUD_TOKEN_ENV_VAR_NAME_VALUE[0]] = DAGGER_CLOUD_TOKEN_ENV_VAR_NAME_VALUE[1] | ||
exit_code = 0 | ||
if sys.argv[1] == "--no-tui": | ||
if len(sys.argv) > 1 and sys.argv[1] == "--no-tui": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a bug with the latest changes here when no args were passed to airbyte-ci |
||
command = ["airbyte-ci-internal"] + sys.argv[2:] | ||
else: | ||
dagger_path = check_dagger_cli_install() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,9 @@ | |
{% if dagger_logs_url %} | ||
<li><b><a href="{{ dagger_logs_url }}">Dagger logs</a></b></li> | ||
{% endif %} | ||
{% if dagger_cloud_url %} | ||
<li><b><a href="{{ dagger_cloud_url }}">Dagger Cloud UI</a></b></li> | ||
{% endif %} | ||
</ul> | ||
<h2>Summary</h2> | ||
<table> | ||
|
@@ -169,6 +172,6 @@ | |
</div> | ||
</div> | ||
{% endfor %} | ||
<p style="margin-top: 50px"><em>These reports are generated from <a href="https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connector_ops/connector_ops/pipelines/tests/templates/test_report.html.j2">this code</a>, please reach out to the Connector Operations team for support.</em></p> | ||
<p style="margin-top: 50px"><em>These reports are generated from <a href="https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/pipelines/tests/templates/test_report.html.j2">this code</a>, please reach out to the Connector Operations team for support.</em></p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This link was wrong after the move |
||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't you already logging this on line 481?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a different Report's
print
. One is ConnectorReport.print and the other is Report.print