Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources for init container not specified into helpers/_pods.tpl #808

Closed
3 of 4 tasks
zippo761 opened this issue Dec 4, 2023 · 0 comments · Fixed by #855
Closed
3 of 4 tasks

Resources for init container not specified into helpers/_pods.tpl #808

zippo761 opened this issue Dec 4, 2023 · 0 comments · Fixed by #855
Labels
kind/enhancement kind - new features or changes
Milestone

Comments

@zippo761
Copy link

zippo761 commented Dec 4, 2023

Checks

Motivation

In my compary use strong rules into k8s production cluster that resource quota must be specified for every container. So every deploy without resources into init-containers i catch WARNING like this for every pods (that contain init-container/check-db/wait-for-db-migrations/install-pip-packages:
image_2023-12-04_19-40-54

Implementation

Im propose specified resource into template charts/airflow/templates/_helpers/pods.tpl and fill values for template
somethink like this:

.Values.airflow.

# resource for check-db init container
checkDb:
  resources: {}

# resource for wait-for-db-migrations container
waitForDbMigrations:
  resources: {}

# resource for install-pip-packages container
installPipPackages:
  resources: {} 

and users after this update use only values for avoid this warning

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@zippo761 zippo761 added the kind/enhancement kind - new features or changes label Dec 4, 2023
@zippo761 zippo761 changed the title Resources for init container not set by default Resources for init container not specified into helpers/_pods.tpl Dec 4, 2023
@thesuperzapper thesuperzapper added this to the airflow-8.9.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants