Adding error handling for iOS #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnsimbe
commented
Jul 8, 2023
Comment on lines
+119
to
+136
| PackageInfo packageInfo = await PackageInfo.fromPlatform(); | ||
| final retryClient = RetryClient( | ||
| http.Client(), | ||
| retries: 10, | ||
| ); | ||
|
|
||
| await retryClient.post( | ||
| Uri.parse(Config.slackWebhookUrl), | ||
| headers: { | ||
| HttpHeaders.contentTypeHeader: 'application/json', | ||
| }, | ||
| body: jsonEncode({ | ||
| 'text': "Exception: ${exception.toString()}\n\n " | ||
| "App details: $packageInfo\n\n " | ||
| "StackTrace: $stackTrace\n\n", | ||
| }), | ||
| ); | ||
| } catch (e) { |
There was a problem hiding this comment.
Sending errors slack
Comment on lines
+30
to
+36
| if (!Platform.isAndroid) { | ||
| if (fatal) { | ||
| await AirqoApiClient.sendErrorToSlack(exception as Object, stackTrace); | ||
| } | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
Sending iOS errors to slack
noahnsimbe
commented
Jul 9, 2023
Comment on lines
-62
to
-66
| static String get placesSearchUrl => | ||
| 'https://maps.googleapis.com/maps/api/place/'; | ||
|
|
||
| static String get appStoreUrl => | ||
| 'https://apps.apple.com/ug/app/airqo-monitoring-air-quality/id1337573091'; |
Comment on lines
-113
to
-118
| Future<AppStoreVersion?> latestVersion() async { | ||
| AppStoreVersion? appStoreVersion; | ||
|
|
||
| try { | ||
| final PackageInfo packageInfo = await PackageInfo.fromPlatform(); | ||
|
|
There was a problem hiding this comment.
logic transferred to API
Comment on lines
-15
to
+20
| if (queryParams.isNotEmpty) { | ||
| url = '$url?'; | ||
| queryParams.forEach( | ||
| (key, value) { | ||
| url = queryParams.keys.first.compareTo(key) == 0 | ||
| ? '$url$key=$value' | ||
| : '$url&$key=$value'; | ||
| }, | ||
| ); | ||
| } | ||
| String formattedUrl = '$url?TOKEN=${Config.airqoApiV2Token}'; | ||
| queryParams | ||
| .forEach((key, value) => formattedUrl = "$formattedUrl&$key=$value"); |
There was a problem hiding this comment.
Simplifying the code
Comment on lines
-692
to
-700
| // checking first code | ||
| if (versionSections.first > candidateSections.first) return 1; | ||
|
|
||
| if (versionSections.first < candidateSections.first) return -1; | ||
|
|
||
| // checking second code | ||
| if (versionSections[1] > candidateSections[1]) return 1; | ||
|
|
||
| if (versionSections[1] < candidateSections[1]) return -1; |
There was a problem hiding this comment.
Logic transferred to the APIs
Update rest_api.dart
noahnsimbe
force-pushed
the
mobile-error-handling
branch
from
8b54eb5
to
72cbaf0
Compare
Baalmart
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
thanks @noahnsimbe , this looks good to me! Thanks!
Based on the details of the PR, I will just go ahead and merge it to make things timely!
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes (What does this PR do?)
Status of maturity (all need to be checked before merging):
How should this be manually tested?
What are the relevant tickets?
Screenshots (optional)