-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding error handling for iOS #1334
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
447cbd8
add error handling for iOS
noahnsimbe 2c2e176
refactor query parameters
noahnsimbe 6307f45
Logging iOS errors to slack
noahnsimbe 2552cda
cleanup
noahnsimbe baf16fa
add update to app versions
noahnsimbe 6e5f421
removed un used tests
noahnsimbe 72cbaf0
Error reporting
noahnsimbe c363dd2
fix - failing tests
noahnsimbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,9 @@ | ||
import 'dart:io'; | ||
|
||
import 'package:app/blocs/blocs.dart'; | ||
import 'package:app/constants/constants.dart'; | ||
import 'package:app/models/models.dart'; | ||
import 'package:app/utils/utils.dart'; | ||
import 'package:flutter/material.dart'; | ||
import 'package:flutter_bloc/flutter_bloc.dart'; | ||
import 'package:package_info_plus/package_info_plus.dart'; | ||
import 'package:shared_preferences/shared_preferences.dart'; | ||
|
||
import 'firebase_service.dart'; | ||
|
@@ -75,7 +72,7 @@ class AppService { | |
|
||
return true; | ||
} catch (exception, stackTrace) { | ||
logException(exception, stackTrace); | ||
await logException(exception, stackTrace); | ||
|
||
return false; | ||
} | ||
|
@@ -109,35 +106,4 @@ class AppService { | |
), | ||
); | ||
} | ||
|
||
Future<AppStoreVersion?> latestVersion() async { | ||
AppStoreVersion? appStoreVersion; | ||
|
||
try { | ||
final PackageInfo packageInfo = await PackageInfo.fromPlatform(); | ||
|
||
if (Platform.isAndroid) { | ||
Comment on lines
-113
to
-118
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic transferred to API |
||
appStoreVersion = await AirqoApiClient() | ||
.getAppVersion(packageName: packageInfo.packageName); | ||
} else if (Platform.isIOS) { | ||
appStoreVersion = await AirqoApiClient() | ||
.getAppVersion(bundleId: packageInfo.packageName); | ||
} else { | ||
return appStoreVersion; | ||
} | ||
|
||
if (appStoreVersion == null) return null; | ||
|
||
return appStoreVersion.compareVersion(packageInfo.version) >= 1 | ||
? appStoreVersion | ||
: null; | ||
} catch (exception, stackTrace) { | ||
await logException( | ||
exception, | ||
stackTrace, | ||
); | ||
} | ||
|
||
return appStoreVersion; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup