Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRRP Cleanup #121

Closed
eak13 opened this issue Apr 5, 2021 · 5 comments
Closed

VRRP Cleanup #121

eak13 opened this issue Apr 5, 2021 · 5 comments
Assignees
Labels
2-Manifests Relates to manifest/document set related issues enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release size s <=1 days [refactor, 1 function, documentation]
Milestone

Comments

@eak13
Copy link

eak13 commented Apr 5, 2021

To correct the issue raised on VRRP seems to be from the json6902patch merge construct.
The below attributes to be added to the preKubeadmCommands as a part of the list but it has ended up concatenating both the lines which is leading to the issue.

  • op: add
    path: "/spec/kubeadmConfigSpec/preKubeadmCommands/-"
    value:
    apt-get update && apt-get install -y bridge-utils keepalived ipset ipvsadm
    systemctl enable --now keepalived

The fix is to put and additional add op for the second line like below.

  • op: add
    path: "/spec/kubeadmConfigSpec/preKubeadmCommands/-"
    value:
    apt-get update && apt-get install -y bridge-utils keepalived ipset ipvsadm
  • op: add
    path: "/spec/kubeadmConfigSpec/preKubeadmCommands/-"
    value:
    systemctl enable --now keepalived

Also remove the apt-get install/update as it should be addressed in image builder #10 . This needs to be remove this line as part of the fix.

@eak13 eak13 added enhancement New feature or request triage labels Apr 5, 2021
@manojkva
Copy link
Contributor

manojkva commented Apr 5, 2021

Please assign this to me

@eak13
Copy link
Author

eak13 commented Apr 5, 2021

@manojkva done

@eak13 eak13 added priority/critical Items critical to be implemented, usually by the next release and removed triage labels Apr 5, 2021
@eak13 eak13 added this to the v2.0 milestone Apr 5, 2021
@eak13 eak13 added the 2-Manifests Relates to manifest/document set related issues label Apr 5, 2021
@michaelfix
Copy link

For documentation only - Manoj's PS is https://review.opendev.org/c/airship/treasuremap/+/784790

@eak13 eak13 added the size s <=1 days [refactor, 1 function, documentation] label Apr 5, 2021
@manojkva
Copy link
Contributor

manojkva commented Apr 6, 2021

Can be closed as the fix is merged.

@eak13
Copy link
Author

eak13 commented Apr 6, 2021

Closing per merge

@eak13 eak13 closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Manifests Relates to manifest/document set related issues enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release size s <=1 days [refactor, 1 function, documentation]
Projects
None yet
Development

No branches or pull requests

3 participants