fixed templates modal and fixed type template with api change #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudreyKj
requested review from
AitorAlgorta,
ogbeche77,
stayprodio and
bitboxer
lucapette
reviewed
Mar 15, 2021
| @@ -5,5 +5,5 @@ export interface Template { | |||
| name: string; | |||
| sourceType: SourceType; | |||
| content: string; | |||
| variables: any; | |||
| variables?: any; | |||
There was a problem hiding this comment.
I'm removing this from the api as its introduction was premature (I planned to remove it from here as well but since we're at it we can do here)
There was a problem hiding this comment.
ahh ok, I thought it was only becoming optional! thanks for the update :)
lucapette
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1249
(i'm opening the PR, but we can add more small UI fix to it if needed)
changes: