Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1611] Aligned svg files #1810

Merged
merged 3 commits into from
May 19, 2021
Merged

[#1611] Aligned svg files #1810

merged 3 commits into from
May 19, 2021

Conversation

stayprodio
Copy link
Contributor

With this PR all svg's are aligned and can be styled via css (just giving width and height).
We keep the viewBox to keep the aspect ratio of each svg so it doesn't brakes when change the size

Copy link
Contributor

@AudreyKj AudreyKj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing :) 💯

Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

King of SVGs

@@ -15,7 +15,7 @@ export const GoogleBusinessMessagesRequirementsDialog = (props: GoogleBusinessMe
<div className={styles.backgroundContainer}>
<div className={styles.container}>
<button className={styles.closeButton} onClick={() => props.onClose()}>
<img src={close} />
<CloseIcon />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@stayprodio stayprodio merged commit a996790 into develop May 19, 2021
@stayprodio stayprodio deleted the fix/1611-fix-svg-viewBox branch May 19, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants