Generate typescript definitions from content model #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
requested review from
AitorAlgorta,
bitboxer,
lucapette,
paulodiniz and
stayprodio
chrismatix
commented
Nov 6, 2020
| @@ -19,6 +19,17 @@ java_library( | |||
| deps = lib_deps, | |||
| ) | |||
|
|
|||
| java_binary( | |||
There was a problem hiding this comment.
@lucapette and @paulodiniz as long as we don't want to create ts definitions for anything else (which I think makes sense, because this problem is so unique), I would keep the generator as a binary that is local to this package.
chrismatix
commented
Nov 6, 2020
| text: string; | ||
| } | ||
|
|
||
| export type ContentUnion = Text; |
There was a problem hiding this comment.
With this, we can build a switch { case } function in the components lib that takes a Content payload and depending on the type field returns a react component.
chrismatix
force-pushed
the
generate-typescript-defs
branch
from
3abba2b
to
3d829a1
Compare
|
Nice work! |
chrismatix
commented
Nov 9, 2020
| parameters.debug = false; | ||
| parameters.classNamePatterns = List.of("co.airy.mapping.model.**"); | ||
|
|
||
| final File output = new File(System.getenv().get("BUILD_WORKSPACE_DIRECTORY") + "/frontend/components/src/content.ts"); |
There was a problem hiding this comment.
In the same spirit, everything here is hardcoded on purpose.
chrismatix
force-pushed
the
generate-typescript-defs
branch
from
3d829a1
to
82a4476
Compare
paulodiniz
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #217