Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#403] Filter for conversations #744

Merged
merged 25 commits into from
Jan 29, 2021
Merged

[#403] Filter for conversations #744

merged 25 commits into from
Jan 29, 2021

Conversation

AitorAlgorta
Copy link
Contributor

@AitorAlgorta AitorAlgorta marked this pull request as draft January 26, 2021 13:57
@AitorAlgorta AitorAlgorta marked this pull request as ready for review January 27, 2021 15:03
chrismatix
chrismatix reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@chrismatix chrismatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Good work 🎉

frontend/demo/src/actions/conversationsFilter/index.ts Outdated Show resolved Hide resolved
frontend/chat-plugin/src/airyRenderProps/AiryInputBar/index.tsx Outdated Show resolved Hide resolved
frontend/demo/src/actions/conversationsFilter/index.ts Outdated Show resolved Hide resolved
frontend/demo/src/components/SimpleIconChannel/index.tsx Outdated Show resolved Hide resolved
frontend/demo/src/components/SimpleIconChannel/index.tsx Outdated Show resolved Hide resolved
frontend/demo/src/pages/Inbox/ConversationList/index.tsx Outdated Show resolved Hide resolved
frontend/demo/src/reducers/data/conversations/index.ts Outdated Show resolved Hide resolved
infrastructure/airy.conf Outdated Show resolved Hide resolved
bitboxer
bitboxer reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@bitboxer bitboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

frontend/demo/src/actions/conversationsFilter/index.ts Outdated Show resolved Hide resolved
frontend/demo/src/components/Dialog/index.tsx Show resolved Hide resolved
frontend/demo/src/components/DialogCustomizable/index.tsx Show resolved Hide resolved
lucapette
lucapette approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AitorAlgorta AitorAlgorta merged commit 3383343 into develop Jan 29, 2021
@AitorAlgorta AitorAlgorta deleted the feature/403-filter-conversations branch January 29, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitboxer bitboxer bitboxer left review comments

@chrismatix chrismatix chrismatix left review comments

@lucapette lucapette lucapette approved these changes

@stayprodio stayprodio Awaiting requested review from stayprodio

@AudreyKj AudreyKj Awaiting requested review from AudreyKj

@ogbeche77 ogbeche77 Awaiting requested review from ogbeche77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AitorAlgorta @bitboxer @lucapette @chrismatix