[#918] Consume Airy Events from new websocket in the UI #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
commented
Feb 16, 2021
| @@ -109,6 +110,7 @@ private void startStream() { | |||
|
|
|||
| // produce unread count metadata | |||
| messageStream.selectKey((messageId, message) -> message.getConversationId()) | |||
| .filter((conversationId, message) -> isFromContact(message)) | |||
There was a problem hiding this comment.
Fixes a bug wherein unread counts where increased for messages sent from Airy
chrismatix
requested review from
bitboxer,
AudreyKj and
stayprodio
and removed request for
bitboxer and
AudreyKj
chrismatix
removed request for
bitboxer,
stayprodio,
AudreyKj,
AitorAlgorta,
ogbeche77 and
paulodiniz
chrismatix
force-pushed
the
feat/use-airy-event-websocket
branch
from
26db359
to
c124aee
Compare
chrismatix
requested review from
bitboxer and
AudreyKj
and removed request for
bitboxer
chrismatix
requested review from
bitboxer,
AitorAlgorta,
lucapette,
ogbeche77,
paulodiniz and
stayprodio
and removed request for
AudreyKj
chrismatix
commented
Feb 17, 2021
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| "rules": { | |||
| "react/prop-types": 0, | |||
| "@typescript-eslint/no-unused-vars": ["error", {"varsIgnorePattern": "_"}], | |||
There was a problem hiding this comment.
We should always provide a reason when changing the rules: This is very useful when you want to remove properties from an object by destructuring. I.e.
const {name, ...dataWithOutName} = contact;You don't need the name here, but need to state it explicitly
chrismatix
force-pushed
the
feat/use-airy-event-websocket
branch
from
6768dd3
to
1db2eab
Compare
chrismatix
force-pushed
the
feat/use-airy-event-websocket
branch
from
1db2eab
to
14eb5ec
Compare
bitboxer
reviewed
Feb 17, 2021
paulodiniz
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #918