We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the test script, definitions such as config_json are duplicated in BaseTest and conftest.py. I think it's better to organize.
actual, def test_init(self, config_json): options = { 'config': self.config_json, The argument config_json is not used. There are other similar cases.
https://github.com/aistairc/aiaccel/blob/main/tests/unit/scheduler_test/test_abstract_scheduler.py#L48-L50
https://github.com/aistairc/aiaccel/blob/main/tests/conftest.py#L92
https://github.com/aistairc/aiaccel/blob/main/tests/base_test.py#L203
test scriptで、例えば、config_jsonなどの定義が、BaseTestとconftest.pyで重複している。 整理した方が良いと思う。
実際、 def test_init(self, config_json): options = { 'config': self.config_json, で引数のconfig_jsonは使われていない。 他にも似たような事例がある。
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In the test script, definitions such as config_json are duplicated in BaseTest and conftest.py.
I think it's better to organize.
actual,
def test_init(self, config_json):
options = {
'config': self.config_json,
The argument config_json is not used.
There are other similar cases.
https://github.com/aistairc/aiaccel/blob/main/tests/unit/scheduler_test/test_abstract_scheduler.py#L48-L50
https://github.com/aistairc/aiaccel/blob/main/tests/conftest.py#L92
https://github.com/aistairc/aiaccel/blob/main/tests/base_test.py#L203
test scriptで、例えば、config_jsonなどの定義が、BaseTestとconftest.pyで重複している。
整理した方が良いと思う。
実際、
def test_init(self, config_json):
options = {
'config': self.config_json,
で引数のconfig_jsonは使われていない。
他にも似たような事例がある。
The text was updated successfully, but these errors were encountered: