Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the test script, definitions such as config_json are duplicated in BaseTest and conftest.py. #219

Closed
koba-22 opened this issue Feb 13, 2023 · 0 comments

Comments

@koba-22
Copy link
Contributor

koba-22 commented Feb 13, 2023

In the test script, definitions such as config_json are duplicated in BaseTest and conftest.py.
I think it's better to organize.

actual,
def test_init(self, config_json):
options = {
'config': self.config_json,
The argument config_json is not used.
There are other similar cases.

https://github.com/aistairc/aiaccel/blob/main/tests/unit/scheduler_test/test_abstract_scheduler.py#L48-L50

https://github.com/aistairc/aiaccel/blob/main/tests/conftest.py#L92

https://github.com/aistairc/aiaccel/blob/main/tests/base_test.py#L203

test scriptで、例えば、config_jsonなどの定義が、BaseTestとconftest.pyで重複している。
整理した方が良いと思う。

実際、
def test_init(self, config_json):
options = {
'config': self.config_json,
で引数のconfig_jsonは使われていない。
他にも似たような事例がある。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants