pg: don't hard code major versions in upgrade_check task #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laysauchoa
reviewed
Jan 12, 2022
rominf
approved these changes
Jan 13, 2022
Instead of hard coding the supported versions just make sure the version consists of digits only. The API will not accept invalid versions anyway. This will allow performing the upgrade_check for - and subsequently upgrading to - pg14 (and upcoming versions, as soon as they are offered).
carobme
force-pushed
the
carobme-pg-versions
branch
from
30e27e7
to
d71f27f
Compare
carobme
changed the title
rominf
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard coding the supported versions just make sure the version
consists of digits only. The API will not accept invalid versions anyway.
This will allow performing the upgrade_check for - and subsequently
upgrading to - pg14 (and upcoming versions, as soon as they are offered).