Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option not to revoke token on logout #271

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Feb 9, 2022

About this change: What it does, why it matters

Keep the current logout behavior by default, but make it possible not to
revoke the token on logout.

$ avn user logout --no-token-revoke

Fix #253.

Keep the current logout behavior by default, but make it possible not to
revoke the token on logout.

```
$ avn user logout --no-token-revoke
```

Fix #253.
@rominf rominf requested a review from a team as a code owner February 9, 2022 08:56
Copy link
Contributor

@dmitrii-vasilev dmitrii-vasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitrii-vasilev dmitrii-vasilev merged commit ecf8cb0 into master Feb 9, 2022
@dmitrii-vasilev dmitrii-vasilev deleted the rominf-user-logout-do-not-revoke-token branch February 9, 2022 11:56
@edbighead
Copy link

edbighead commented Feb 9, 2022

Automatically revoking token after logout command is not quite intuitive and can be misinterpreted if not written in big bold red font in documentation.
https://developer.aiven.io/docs/tools/cli/user.html#avn-user-logout
image

Thinking whether avn user logout --token-revoke is a more user friendly way ?

@rominf
Copy link
Contributor Author

rominf commented Feb 9, 2022

@edbighead Thanks for your opinion.

Automatically revoking token after logout command is not quite intuitive
Thinking whether avn user logout --token-revoke is a more user friendly way ?

  1. I would argue that logout that doesn't invalidate the access token doesn't sound like logout.
  2. It's the current behavior, we don't want break current user setups.

if not written in big bold red font in documentation

I agree about the point in the documentation, but I think that the red font and the size are extra. What do you think @aiven/aiven-devrel?

@lornajane
Copy link
Contributor

I am pretty sure our API tooling doesn't support stylesheets. The wording update would be really good to add though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access token passed with --token flag gets revoked after logout command
4 participants