Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Redis services in cli and connection-info commands #275

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

ngilles-aiven
Copy link
Member

This PR add support for Redis services to the cli and connection-info commands to make it easier to interact with a Redis service in the command line with the help of the avn client.

@ngilles-aiven ngilles-aiven marked this pull request as ready for review February 18, 2022 16:55
@ngilles-aiven ngilles-aiven requested a review from a team as a code owner February 18, 2022 16:55
rominf
rominf previously requested changes Mar 7, 2022
Copy link
Contributor

@rominf rominf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a thorough review, but some changes are needed for sure.

mypy.ini Outdated Show resolved Hide resolved
aiven/client/connection_info/redis.py Outdated Show resolved Hide resolved
aiven/client/connection_info/redis.py Outdated Show resolved Hide resolved
aiven/client/connection_info/redis.py Outdated Show resolved Hide resolved
aiven/client/connection_info/redis.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dmitrii-vasilev dmitrii-vasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. Otherwise looks good.

aiven/client/connection_info/redis.py Show resolved Hide resolved
aiven/client/cli.py Show resolved Hide resolved
@ngilles-aiven ngilles-aiven marked this pull request as draft March 21, 2022 07:17
@ngilles-aiven ngilles-aiven marked this pull request as ready for review March 21, 2022 10:25
@ngilles-aiven ngilles-aiven dismissed stale reviews from rominf and dmitrii-vasilev March 21, 2022 10:26

changes addressed

Copy link
Contributor

@dmitrii-vasilev dmitrii-vasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitrii-vasilev dmitrii-vasilev merged commit 351b8c0 into master Mar 21, 2022
@dmitrii-vasilev dmitrii-vasilev deleted the ngilles-add-redis-cli-support branch March 21, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants