Add initial support for creating OAuth2 apps #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-novikov
force-pushed
the
m-novikov-oauth2-cli
branch
from
9531d0a
to
4a1924f
Compare
m-novikov
force-pushed
the
m-novikov-oauth2-cli
branch
from
4a1924f
to
dabe8a8
Compare
sjamgade
previously requested changes
Mar 25, 2022
aiven/client/client.py
Outdated
| body={"redirect_uri": uri}, | ||
| ) | ||
|
|
||
| def add_oauth2_client_secret(self, account_id: str, client_id: str) -> Mapping: |
There was a problem hiding this comment.
shouldnt this be get_oauth2.... ?
There was a problem hiding this comment.
Maybe create? It does post request and issues new one.
| ) | ||
| def account__oauth2_client__create(self): | ||
| """Create new OAuth2 client.""" | ||
| oauth2_client = self.client.create_oauth2_client( |
There was a problem hiding this comment.
if something blows up down the line, the client will persist.
Either remove the client then and there or allow it to be removed later ?
m-novikov
force-pushed
the
m-novikov-oauth2-cli
branch
from
dabe8a8
to
6186343
Compare
tvainika
changed the title
|
@tvainika did you want to take a look at this ? |
rominf
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change: What it does, why it matters
Adds ability to configure OAuth2 apps for users.
As we are moving to allow third-party providers to integrate with aiven services it's helpful to have convenient interface to configure oauth2 apps.