Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further support for managing OAuth2 client apps configurations #288

Merged
merged 1 commit into from
May 30, 2022

Conversation

ngilles-aiven
Copy link
Member

No description provided.

@ngilles-aiven ngilles-aiven marked this pull request as ready for review May 9, 2022 15:49
@ngilles-aiven ngilles-aiven requested a review from a team as a code owner May 9, 2022 15:49
Copy link

@m-novikov m-novikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goot, but has issue with naming though. We generally use singluar forms for commands e.g. user-list so

  • secrets-list -> secret-list
  • redirects-list -> redirect-list
    Also verbs create instead of add and delete instead of remove

@lornajane
Copy link
Contributor

If you're adding commands to the client, could you also add them to the docs, at least as a reference even if we build the proper usage example later? https://developer.aiven.io/docs/tools/cli.html

@ngilles-aiven ngilles-aiven marked this pull request as draft May 11, 2022 06:58
@ngilles-aiven ngilles-aiven marked this pull request as ready for review May 17, 2022 07:18
@ngilles-aiven ngilles-aiven requested review from a team and m-novikov May 24, 2022 08:04
@m-novikov m-novikov merged commit 8492a64 into main May 30, 2022
@m-novikov m-novikov deleted the ngilles-oauth2-commands branch May 30, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants