Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kafka Schema Registry ACL #294

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

juha-aiven
Copy link
Contributor

@juha-aiven juha-aiven commented Jun 20, 2022

Add support for Kafka Schema Registry authorization.

Add commands to add, list and delete Schema Registry ACL entries.

Add parameters to service update call to be able to toggle authorization on and off.

@juha-aiven juha-aiven force-pushed the juham-kafka-schema-registry-acl branch from 6710a63 to caad3de Compare June 20, 2022 13:47
aiven/client/client.py Outdated Show resolved Hide resolved
aiven/client/client.py Outdated Show resolved Hide resolved
@juha-aiven juha-aiven force-pushed the juham-kafka-schema-registry-acl branch from caad3de to 8162386 Compare June 28, 2022 07:55
@juha-aiven juha-aiven marked this pull request as ready for review June 28, 2022 12:50
@juha-aiven juha-aiven requested a review from a team as a code owner June 28, 2022 12:50
Copy link
Member

@tvainika tvainika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's merge this (only) after new APIs have been deployed to production?

@juha-aiven
Copy link
Contributor Author

Let's merge this (only) after new APIs have been deployed to production?

+1

@ivanyu
Copy link
Member

ivanyu commented Jun 29, 2022

Let's merge this (only) after new APIs have been deployed to production?

But we need also to make a release to officially make the feature available, until then we are free to change this functionality

@tvainika
Copy link
Member

But we need also to make a release to officially make the feature available, until then we are free to change this functionality

A good point. I'll merge this right away, and after these features are generally available in the production, then let's make a release of aiven-client officially.

@tvainika tvainika merged commit 4142eac into main Jun 30, 2022
@tvainika tvainika deleted the juham-kafka-schema-registry-acl branch June 30, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants