Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Follower fetching image #357

Merged
merged 1 commit into from
Jul 31, 2024
Merged

add: Follower fetching image #357

merged 1 commit into from
Jul 31, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Jul 31, 2024

Describe your changes

Added an image to the "How it works" section of the Follower fetching concept topic.

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review July 31, 2024 11:15
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner July 31, 2024 11:15
@harshini-rangaswamy harshini-rangaswamy changed the title Add: Follower fetching image add: Follower fetching image Jul 31, 2024
Copy link

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a649e8b
Status: ✅  Deploy successful!
Preview URL: https://7d2aff40.aiven-docs.pages.dev
Branch Preview URL: https://harshini-ff-image.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy added the review/TW A TW must review the PR. Comes after review/SME. label Jul 31, 2024
@harshini-rangaswamy harshini-rangaswamy self-assigned this Jul 31, 2024
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you'd like to have the images larger on the doc page, you might consider splitting them into separate tabs so that each of them can stretch to the page width.

@harshini-rangaswamy
Copy link
Contributor Author

LGTM! If you'd like to have the images larger on the doc page, you might consider splitting them into separate tabs so that each of them can stretch to the page width.

Thanks! It is actually one image showing the difference between standard Kafka consumers vs. Follower fetching Kafka consumers.

@harshini-rangaswamy harshini-rangaswamy merged commit c710bf8 into main Jul 31, 2024
4 of 10 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-ff-image branch July 31, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review/TW A TW must review the PR. Comes after review/SME. service/kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants