Only enable the failover fix if configured #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packi
force-pushed
the
packi-dont-failover-by-default
branch
3 times, most recently
from
0887c26
to
780f52d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 68.88% 69.14% +0.25%
==========================================
Files 10 10
Lines 990 995 +5
Branches 173 174 +1
==========================================
+ Hits 682 688 +6
+ Misses 253 252 -1
Partials 55 55
☔ View full report in Codecov by Sentry. |
packi
force-pushed
the
packi-dont-failover-by-default
branch
from
780f52d
to
6c8cc2a
Compare
Mulugruntz
reviewed
May 10, 2023
packi
force-pushed
the
packi-dont-failover-by-default
branch
from
6c8cc2a
to
1e6b598
Compare
To be able to roll it out in a more controlled fashion
packi
force-pushed
the
packi-dont-failover-by-default
branch
from
1e6b598
to
0ac108d
Compare
|
The test I've adjusted should cover the feature and the disabling of it. |
Mulugruntz
reviewed
May 22, 2023
Mulugruntz
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to roll it out in a more controlled fashion
BF-1847