Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #84 from aiven/alex-repl-slots-states-cache" [BF-1513] #88

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

alexole
Copy link
Contributor

@alexole alexole commented Nov 17, 2022

Revert replication slots caching functionality, there is a more elegant way to sync replication slots from the master to standbys without cache with some help of extra functionality, which needs to be implemented as extension.

This reverts commit d507d11, reversing changes made to 932331b.

Revert replication slots caching functionality, there is a more elegant
way to sync replication slots from the master to standbys with some help
of extra functionality, which needs to be implemented as extension.

This reverts commit d507d11, reversing
changes made to 932331b.
@alexole alexole marked this pull request as ready for review November 17, 2022 08:02
@alexole alexole requested a review from a team as a code owner November 17, 2022 08:02
@alexole alexole changed the title Revert "Merge pull request #84 from aiven/alex-repl-slots-states-cache" Revert "Merge pull request #84 from aiven/alex-repl-slots-states-cache" [BF-1513] Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 69.29% // Head: 67.90% // Decreases project coverage by -1.38% ⚠️

Coverage data is based on head (0af51c3) compared to base (1e77600).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   69.29%   67.90%   -1.39%     
==========================================
  Files          10       10              
  Lines        1016      969      -47     
  Branches      185      170      -15     
==========================================
- Hits          704      658      -46     
- Misses        252      253       +1     
+ Partials       60       58       -2     
Impacted Files Coverage Δ
pglookout/common.py 100.00% <ø> (ø)
pglookout/cluster_monitor.py 64.50% <100.00%> (-4.06%) ⬇️
pglookout/pglookout.py 68.45% <100.00%> (-0.19%) ⬇️
pglookout/webserver.py 92.59% <100.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@packi packi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@packi packi merged commit 5f61be1 into main Nov 17, 2022
@packi packi deleted the alex-revert-repl-slots-cache branch November 17, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants