Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop items instead of deleting them #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Drop items instead of deleting them #27

wants to merge 6 commits into from

Conversation

BrainStone
Copy link
Contributor

Also taking into consideration that Inventory#remove deletes all items of the same type.

Fixes #26

@BrainStone
Drop items instead of deleting them
f6fa1f7 
Also taking into consideration that `Inventory#remove` deletes all items of the same type.
@BrainStone
Drop item first, then delete it
2796e9e 
This is because if you set the amount to 0 the itemStack becomes air.  Dropping it first gurantuees that this doesn't happen.
@BrainStone
Items need to be dropped synchronously
affec90
@BrainStone
Set proper pickup delay
32d81cf
@BrainStone
Fix duping
469dc9c 
prevCount can be larger than limit
@BrainStone
Dropp all items at once
4793931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop items instead of deleting them
1 participant
@BrainStone