Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SQL keywords: IS and IN #5263

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

wlodi83
Copy link
Contributor

@wlodi83 wlodi83 commented Jul 21, 2023

Description:
This pull request addresses an issue where the SQL keywords 'IS' and 'IN' are not currently highlighted in the editor's SQL mode. To enhance the SQL syntax highlighting and improve the overall user experience, I have added support for highlighting these missing keywords.

is id

Proposed Changes:

Added 'IS' and 'IN' to the list of recognized SQL keywords in the editor's SQL mode.
Updated the syntax highlighting rules to ensure proper rendering of 'IS' and 'IN' in SQL queries.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6549570) 87.23% compared to head (6fa0bff) 87.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5263   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         565      565           
  Lines       45248    45248           
  Branches     6920     6920           
=======================================
  Hits        39470    39470           
  Misses       5778     5778           
Flag Coverage Δ
unittests 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/sql_highlight_rules.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InspiredGuy InspiredGuy merged commit c731164 into ajaxorg:master Jul 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants