Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to set setSelectOnHover for Autocomplete #5317

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Sep 15, 2023

Issue #, if available: NA

Description of changes: Allows setting setSelectOnHover for Autocomplete to make the selected row follow to cursor highlight.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Screen.Recording.2023-09-15.at.13.54.19.mov

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (921e488) 87.28% compared to head (b85105c) 87.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5317      +/-   ##
==========================================
+ Coverage   87.28%   87.33%   +0.05%     
==========================================
  Files         574      574              
  Lines       45440    45482      +42     
  Branches     6932     6934       +2     
==========================================
+ Hits        39663    39723      +60     
+ Misses       5777     5759      -18     
Flag Coverage Δ
unittests 87.33% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/autocomplete.js 81.97% <100.00%> (+0.07%) ⬆️
src/autocomplete_test.js 98.26% <100.00%> (+0.27%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman changed the title Allow to set setSelectOnHover for Autocomplete feat: Allow to set setSelectOnHover for Autocomplete Sep 15, 2023
@akoreman akoreman merged commit dccbcc2 into ajaxorg:master Sep 15, 2023
3 checks passed
@akoreman akoreman deleted the completion-selection branch September 15, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants