Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve type getMarkerAtPosition markergroup #5631

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: getMarkerAtPosition uses Array.find to find the matching marker. When the position we search at doesn't have any markers, this returns undefined which we currently don't include in the exported type.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (4befc2c) to head (0be8f37).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5631   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         594      594           
  Lines       43395    43395           
  Branches     7170     7170           
=======================================
  Hits        37742    37742           
  Misses       5653     5653           
Flag Coverage Δ
unittests 86.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 89bd40a into ajaxorg:master Aug 26, 2024
4 checks passed
@akoreman akoreman deleted the markergroup_types branch August 26, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants