Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling the gutter no longer collapses the lines to the left #59

Closed
MikeRatcliffe opened this issue Jan 26, 2011 · 2 comments
Closed

Comments

@MikeRatcliffe
Copy link

Toggling the gutter no longer collapses the lines to the left. This is easy to see using:
env.editor.renderer.setShowGutter(!env.editor.renderer.showGutter);

Resizing the window fixes them but strangely calling window.resize() doesn't. After resizing the window toggling the gutter again means that the line is on top of the gutter.

@nightwing
Copy link
Member

onResize does nothing because width isn't changed
nightwing@c6748d9

this solves immediate problem but there's still several issues here

  1. onresize doesn't update layers when scroller underflows
  2. doesn't update ace_content when scroller overflows (this results in scrollbar flashing while resizing)
  3. longest line needed for those is expensive (linear with file size, it should use change deltas here)

@fjakobs
Copy link
Contributor

fjakobs commented Jan 28, 2011

I think this is solved. Since toggling the gutter is not likely a fequent operation the flashing of the scrollbar and the linear time with line numbers should be ok.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants