Highlight more #3451
Merged
Highlight more #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightwing
force-pushed
the
highlight-more
branch
from
c99442f
to
ff839dc
Compare
lennartcl
approved these changes
Nov 21, 2017
| return parent.appendChild(document.createTextNode(str)) | ||
| } | ||
| function clearEl(el, l) { | ||
| while (l --> 0) |
There was a problem hiding this comment.
Very cute but are you sure we should use that trick? Sometimes smart code like this triggers questions or causes people to make the wrong assumptions.
There was a problem hiding this comment.
Well this is in experiments, so using the trick is not very harmful, but i'll remove this later, when i add one more drawing method to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes #3439 #3202