Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please stop broken UA-sniffing for Gecko and use of deprecated "text" event and use "compositionupdate" events #3202

Closed
bzbarsky opened this issue Feb 7, 2017 · 0 comments
Closed

Please stop broken UA-sniffing for Gecko and use of deprecated "text" event and use "compositionupdate" events #3202

bzbarsky opened this issue Feb 7, 2017 · 0 comments

Comments

@bzbarsky
Copy link

bzbarsky commented Feb 7, 2017

There is code in textinput.js that conditions on isGecko and listens for "text" events (which are deprecated). The way isGecko is computed in useragent.js relies on non-standard properties that Gecko plans to remove.

What you should probably do is stop UA-sniffing and just use compositionupdate events instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nightwing @bzbarsky