Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a folder into Cinny (should not be possible) #621

Closed
wj25czxj47bu6q opened this issue Jun 11, 2022 · 1 comment
Closed

Dragging a folder into Cinny (should not be possible) #621

wj25czxj47bu6q opened this issue Jun 11, 2022 · 1 comment
Labels
area: room-input type: bug Something isn't working

Comments

@wj25czxj47bu6q
Copy link

wj25czxj47bu6q commented Jun 11, 2022

Describe the bug

Dragging a folder into Cinny (from a file manager) succeeds in attaching the 'file'.

Attempting to send the attachment fails (as expected). If there is a typed message, that part will go through as normal.

Attempting to remove the attachment (via the circled-X cancel button) works as normal before attempting to send the attachment. After a send attempt, the attachment cancel button no longer works — it is unclear if this is merely a UI bug or if Cinny continues attempting to send the attachment. The only way to remove the attachment at this point is to drag a new file (or even the same folder) into Cinny and then use the attachment cancel button on the new attachment (pasting an image or file does not work, and the upload button to open the file chooser is hidden).

Reproduction

  1. Drag and drop an arbitrary folder into Cinny. It does not matter if the folder is empty or has contents.
  2. Experience undesired behaviors as documented above.

image

image

Expected behavior

Attempting to drag a folder into Cinny should have no effect and be ignored.

Element does not handle this perfectly either, but at least it promptly gives an error ("The file 'testfolder' failed to upload.") and continues to function normally after that.

Platform and versions

OS: Linux
Browser: Ungoogled Chromium 102 and Cinny Flatpak
Cinny version: 2.0.4
Matrix homeserver: matrix.org and a private one (running Synapse)

Additional context

Cinny appears to create a purely client-side invisible event/message for attachments that fail to send, based on the 'following this conversation' indicator in the bottom-right. Neither that indicator nor anything else changes in other Matrix clients (except of course if there is a text message), including other instances of Cinny, on the same account or a different one looking at the same room.

@ajbura
Copy link
Member

ajbura commented Jul 26, 2024

CInny know shows an error on uploading folder

@ajbura ajbura closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: room-input type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants