New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS In NodeJsScan UI from File / Folder Names. #7

Closed

matt- opened this issue Feb 16, 2017 · 1 comment

Labels

matt- commented Feb 16, 2017

Hey man. Great project. Thank you for your work on this.

I was testing this out and bumped in to an XSS.

Create a zip file with a file named: ');alert(document.domain);('.txt
Upload the zip.
Under "All Files" link under location for the file.
You should see a popup with the xss.

This gets converted into the following HTML:

<a href="javascript:view('e9ce45f4ef683fb3130c00e93a96fd92c63010b0597249012d47c4f80863663d/tester/&#39;);alert(document.domain);(&#39;.txt','0','tester&#39;);alert(document.domain);(&#39;.txt','e9ce45f4ef683fb3130c00e93a96fd92c63010b0597249012d47c4f80863663d');">

The single quote is being html encoded instead of properly escaped for javascript.

Owner

ajinabraham commented Feb 16, 2017

Nice Catch. Should be fixed with: df96847#diff-3f41e546893dc64b71aaacad12cad815

A perfect example of why html escaping provided by the framework is not sufficient against all xss contexts.

ajinabraham closed this as completed

ajinabraham added the security label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment