$cfg_dir has no effect with dns::server::options

[lingfish]

I think this line should be moved into the parameter section.

Even then though, I have to "double" set $cfg_dir (in my hiera, I'm using auto parameter lookup), at dns::server::cfg_dir level, and in options.

What results is this:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid relationship: File[/tmp/bind/named.conf.options] { require => File[/etc/bind] }, because File[/etc/bind] doesn't seem to be in the catalog

Because here is pulling the default params $cfg_dir, and not one I've set.

[lingfish]

Same issue now when adding a zone (when setting $cfg_dir to, say, '/tmp/bind'):

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid relationship: File[/var/lib/puppet/concat/_etc_bind_named.conf.local/fragments/3_named.conf.local.ad.gsoa.ddau.include] { notify => Exec[concat_/etc/bind/named.conf.local] }, because Exec[concat_/etc/bind/named.conf.local] doesn't seem to be in the catalog

[solarkennedy]

I think you are correct. Can you make a PR?

[lingfish]

Being defined types, I'm not yet sure on how to handle it. I'll have a think about it.