Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move anticipate next index 1 in operation._combine to operation.chain #58

Closed
ajkerr0 opened this issue Aug 9, 2016 · 1 comment
Closed

Comments

@ajkerr0
Copy link
Owner

ajkerr0 commented Aug 9, 2016

_combine doesn't need that functionality and makes the function less self-contained. That check can simply be in operation[_plus].chain (since that's the only situation in which it would be needed)

@ajkerr0
Copy link
Owner Author

ajkerr0 commented Aug 9, 2016

My hesitation is that that short little calculation requires understanding how _combine works. If they are in the same module I guess its no big deal. After all I assume how other things work across the package all the time.

ajkerr0 referenced this issue Aug 9, 2016
…on.py

Previous code now exists in operation_old.py.
@ajkerr0 ajkerr0 closed this as completed Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant