Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav ul li href error #24

Closed
syedaliaziz opened this issue Nov 20, 2013 · 11 comments
Closed

nav ul li href error #24

syedaliaziz opened this issue Nov 20, 2013 · 11 comments

Comments

@syedaliaziz
Copy link

I am using skeljs and prologue template. I am facing this issue with menus (nav) - when i put a url like "http://google.com" or "/account/login" it throws this error. The menu is using "#" urls by default - it scrolls sections.

Plese help me in this regards.

jquery nav li a href error
url in this menu.

@syedaliaziz
Copy link
Author

i was search for this issue for a long time - have tried many things - nothing worked

Below is init.js nav section code - i think there is somthing wrong with this section (jquery selector issue or something?).
When I commented scroll links section of nav initialization link worked just fine but menu lost all its styling.

Please help...

Init.js:

// Initialize scrolly links
jQuery('.scrolly').n33_scrolly();

    // Initialize nav
        var $nav_a = jQuery('#nav a');

        // Scrollyfy links
            $nav_a
                .n33_scrolly()
                .click(function(e) {

                    e.preventDefault();

                    // Clear active and lock scrollzer until scrolling has stopped
                        $nav_a
                            .removeClass('active')
                            .addClass('scrollzer-locked');

                    // Set this link to active
                        jQuery(this).addClass('active');
                });

        // Initialize scrollzer
            var ids = [];

            $nav_a.each(function() {
                ids.push(jQuery(this).attr('href').substring(1));
            });

            jQuery.n33_scrollzer(ids, { pad: 200, lastHack: true });

@ajlkn
Copy link
Owner

ajlkn commented Nov 20, 2013

This is likely a template related issue, not skelJS itself. Contact me directly via email for help with this.

@ajlkn ajlkn closed this as completed Nov 20, 2013
@syedaliaziz
Copy link
Author

i have emailed you - kindly help.

Thanks.

@gstett
Copy link

gstett commented Dec 15, 2013

I'm having the same issue. Is it not possible to use external links (i.e., something other than a "#" link, like "http://www.google.com") from within the nav tags?

@gstett
Copy link

gstett commented Dec 16, 2013

Never mind, I found a workaround.

@dougmercer
Copy link

gstett, what was your work around? I've been trying to sort this out myself and haven't found a workaround.

@dougmercer
Copy link

For those having issues with linking to external sites from the nav bar using the prologue template, be sure you are using the latest version of the js files. Download them directly from n33co's website.

@bhsudeep
Copy link

gstett: could you please tell me what is the workaround? I am in the similar situation.

dougmercer: Should I replace all the js files from the latest download ? I am asking because I have made a lot of changes to the base template to suit my need.

n33: its an amazing template. Thank you!

@dougmercer
Copy link

@bhsudeep Yes, I replaced the JS files in full and components of the CSS that I hadn't already modified before realizing I was on the wrong version.

For all JS and CSS files, I used http://www.diffchecker.com/ to help compare the proper version to my modified, incorrect version, and brought the outdated files up-to-date as appropriate.

@bhsudeep
Copy link

@dougmercer Thank you! I replaced all the js and css file after making note of the changes. The href is now working but the main section looks stretched out but I should be able to work with it.

@dougmercer
Copy link

@bhsudeep Hmm, I didn't experience the "stretching" problem you described, so I'm not sure what to suggest there. However, I'm glad you sorted out the href issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants