Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping indicators in board customization page are floating over the header #1997

Closed
4 tasks done
krishnamuppaneni opened this issue Apr 4, 2024 · 2 comments · Fixed by #1998
Closed
4 tasks done

Ping indicators in board customization page are floating over the header #1997

krishnamuppaneni opened this issue Apr 4, 2024 · 2 comments · Fixed by #1998
Labels
🐛 Bug Something isn't working good first issue Good for newcomers

Comments

@krishnamuppaneni
Copy link
Contributor

krishnamuppaneni commented Apr 4, 2024

Environment

Docker

Version

No response

Describe the problem

The ping indicators in the board customization page are floating over the header while scrolling. The z-index of ping indicators is 100 which is the same as the header.

Logs

No response

Context

This is the same issue as #1401

Homarr_Indicators.mp4

Please tick the boxes

  • I confirm that I attached the proper logs
  • I've read the docs
  • I've checked for duplicate issues
  • I've tried to debug myself
@krishnamuppaneni krishnamuppaneni added the 🐛 Bug Something isn't working label Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

Hi 👋. Thank you for submitting your first issue to Homarr. Please ensure that you've provided all nessesary information. You can use the three dots > Edit button to update your post with additional images and information. Depending on the current volume of requests, the team should get in conact with you shortly.

@SeDemal
Copy link
Collaborator

SeDemal commented Apr 4, 2024

The indicator component from mantine seem to always be on top. We had the same problem with the indicators on the calendar a while back. (edit: you actually mentioned the issue I opened about it a while back, and you already made the PR for it. Didn't read all the way through my bad)
Since it's really minor, I'll note it as "good first issue" for anyone trying to pick up on our code.

@SeDemal SeDemal added the good first issue Good for newcomers label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants