Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Dict Response #59

Closed
Haste171 opened this issue May 23, 2023 · 4 comments · Fixed by #60
Closed

JSON Dict Response #59

Haste171 opened this issue May 23, 2023 · 4 comments · Fixed by #60
Labels
feature New feature or request

Comments

@Haste171
Copy link

This is very useful in the use case of conversationalretrievalchain because you need an array of sources to properly format responses on any interface..
@Haste171 Haste171 added the feature New feature or request label May 23, 2023
@ajndkr
Copy link
Owner

ajndkr commented May 23, 2023

Hi! This is already something I’m working on. See #51.

@Haste171
Copy link
Author

Ok, great! My recommendation is that we have a field input like json=True in Streaming Response...

@ajndkr
Copy link
Owner

ajndkr commented May 23, 2023

I like that! I will rework my PR based on this.

@ajndkr ajndkr mentioned this issue May 23, 2023
Merged
@ajndkr
Copy link
Owner

ajndkr commented May 23, 2023

@Haste171 hi! i've added support for JSON streaming in 0.6.5. It should be available soon.

pip install lanarky==0.6.5

let me know if it solves your use case! feel free to open new issues for any improvements or bug fixes. cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add streaming JSON response ajndkr/lanarky
2 participants
@ajndkr @Haste171