Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export formats separately, without scoping #65

Open
o-alexandrov opened this issue May 9, 2022 · 0 comments
Open

Export formats separately, without scoping #65

o-alexandrov opened this issue May 9, 2022 · 0 comments

Comments

@o-alexandrov
Copy link

Related issues

By scoping formats into fullFormats and fastFormats:

  • it's harder to do code generation as it's impossible to import a format in a single line
  • it makes it more complicated not to have multiple imports of the same variable

As a breaking change proposal, let's export two modules instead:

  • formats-fast.js
  • formats-full.js

This way, when doing code generation, it'd be possible to have a single line import:

import { int32 } from "ajv-formats/dist/formats-full"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@o-alexandrov