Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TypeScript definition to DefinitelyTyped #225

Closed
brierel opened this issue Jul 6, 2016 · 7 comments
Closed

Adding TypeScript definition to DefinitelyTyped #225

brierel opened this issue Jul 6, 2016 · 7 comments

Comments

@brierel
Copy link

brierel commented Jul 6, 2016

Hi, I am using ajv in a TypeScript project and only recently figured out you provide a definition file. And that's great.
But I didn't found it on DefinitelyTyped repository. Does someone plan adding it?

@epoberezkin
Copy link
Member

@blakeembrey should it be there?

@blakeembrey
Copy link
Collaborator

No.

@brierel
Copy link
Author

brierel commented Jul 7, 2016

Ok... Can you detail why not? Is it because it declares a namespace, and for public use on DefinitelyTyped we would rather expect a module? This would not involve that much modifications.

@blakeembrey
Copy link
Collaborator

Because the definition is already written and works with typescript. All you have to do is install the module.

@brierel
Copy link
Author

brierel commented Jul 7, 2016

Ok thank you, indeed it makes sense.
ajv module has been effectively in my project dependencies for some time, so I have now to check why the definition file was not correctly detected by WebStorm.

@epoberezkin
Copy link
Member

@blakeembrey thank you!

@onury
Copy link

onury commented Feb 22, 2017

ok. it's in npm/@types. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants