Version Comparison Broken

[andrewcchen]

To reproduce

>>> from libPyKAN.version import Version
>>> Version("1.2") <= Version("1.2.1")
False

Breaks installing mods only compatible with 1.2 on 1.2.1 install with minKSPversion set to 1.2.

[andrewcchen]

Well ... found problem ... easy fix:

diff --git a/libPyKAN/version.py b/libPyKAN/version.py
index 298697d..e8045bd 100644
--- a/libPyKAN/version.py
+++ b/libPyKAN/version.py
@@ -78,7 +78,7 @@ class Version(object):
         if str(self) == 'any' or str(other) == 'any':
             return 0
         if len(other.versionlist) > len(self.versionlist):
-            return other.__cmp__(self)
+            return -other.__cmp__(self)
         for c,i in enumerate(self.versionlist):
             try:
                 j = other.versionlist[c]

[ajventer]

Create a pull request please and I'll merge it.

[ajventer]

Merged. Thanks. Such a silly bug. I spent ages looking for it. That's always how it goes eh - the simplest bugs are the hardest to find.