Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] 1주차 리팩토링-1 #16

Closed
5 tasks done
SangHwi-Back opened this issue May 25, 2022 · 0 comments
Closed
5 tasks done

[Refactor] 1주차 리팩토링-1 #16

SangHwi-Back opened this issue May 25, 2022 · 0 comments
Assignees
@Damagucci-Juice @SangHwi-Back
Labels
📱iOS iOS Issues
Projects
iOS 1주차 칸반
Milestone
iOS 1주차 마일스톤

Comments

@SangHwi-Back
Copy link
Collaborator

SangHwi-Back commented May 25, 2022 •
edited

👨🏻‍💻 작업 내용

현재까지 작성된 클래스 및 함수에서 재사용성이 보장되는 부분을 뽑아 새로운 객체로 만든다.

🔨 작업 목록

  • Search 화면 Main 부분을 확인해본다.
  • Search 화면 커스텀 셀 부분을 확인해본다.
  • Search 화면 공통 컬렉션 뷰 클래스 부분을 확인해본다.
  • UI Test 삭제 Unit Test 그대로 두기
  • 1주차 수요일 피드백을 코드에 반영한다.(각자 리펙터링)
@SangHwi-Back SangHwi-Back changed the title [Refactor] 메인화면 클래스 재사용성 [Refactor] 1주차 리팩토링-1 May 25, 2022
@SangHwi-Back SangHwi-Back added the 📱iOS iOS Issues label May 25, 2022
@SangHwi-Back SangHwi-Back added this to the iOS 1주차 마일스톤 milestone May 25, 2022
SangHwi-Back added a commit that referenced this issue May 25, 2022
@SangHwi-Back
[#16] 불필요한 소스, 주석을 제거합니다.
c024361
SangHwi-Back added a commit that referenced this issue May 25, 2022
@SangHwi-Back
[#16] 네이밍 변경 및 로직 일부 수정
7005f0e
Damagucci-Juice added a commit that referenced this issue May 25, 2022
@Damagucci-Juice
[#16] refactor: 불필요한 주석 제거 및 코드에서 실행되지 않는 부분 제거
e0d64c8
Damagucci-Juice added a commit that referenced this issue May 25, 2022
@Damagucci-Juice
[#16] refactor: 숙소 찾기 화면에서 사용하지 않는 메서드 제거 및 주석 제거
04491e2
Damagucci-Juice added a commit that referenced this issue May 25, 2022
@Damagucci-Juice
Merge pull request #23 from ak2j38/feature-searchRefactor
eb90768 
[#16] refactor: 숙소 찾기 화면에서 사용하지 않는 메서드 제거 및 주석 제거
Damagucci-Juice added a commit that referenced this issue May 25, 2022
@Damagucci-Juice
[#16] Chore: 불필요한 띄어쓰기 제거
6694c07
Damagucci-Juice added a commit that referenced this issue May 26, 2022
@Damagucci-Juice
[#16] hotfix: 1주차 수요일 코드리뷰 반영(구찌)
14dd2c7
Damagucci-Juice added a commit that referenced this issue May 26, 2022
@Damagucci-Juice
[#16] hotfix: 공통 VC에 네이밍 수정
994f712
Damagucci-Juice added a commit that referenced this issue May 26, 2022
@Damagucci-Juice
Merge pull request #34 from ak2j38/hotfix220526gucci
cca9fa6 
[#16] hotfix: 1주차 수요일 코드리뷰 반영(구찌)
@SangHwi-Back SangHwi-Back mentioned this issue May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Damagucci-Juice Damagucci-Juice

@SangHwi-Back SangHwi-Back

Labels
📱iOS iOS Issues
Projects
iOS 1주차 칸반
Awaiting triage
Milestone
iOS 1주차 마일스톤
Development

No branches or pull requests
2 participants
@Damagucci-Juice @SangHwi-Back