[#16] hotfix: 1주차 수요일 코드리뷰 반영(구찌) #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Damagucci-Juice
commented
May 26, 2022
Damagucci-Juice
commented
- 네이밍 관련 편집(navAppearance -> setUpNavigationAppearance)
- searchVC, LocationVC 의 수퍼클래스인 BackgroudViewController 를 선언
- bind(), layout(), attribute(), setUpNavigationAppearance() 등의 메서드들을 수퍼클래스에서 선언하므로 일부는 코드 중복을 줄임
| } | ||
|
|
||
| class BackgroundViewController: UIViewController, BackgroundViewControllerProtocol { | ||
|
|
There was a problem hiding this comment.
해당 클래스는 LocationViewController 에서만 상속받을 클래스인가요? 그렇다면 좀 더 구체적인 이름이 더 좋을 것 같습니다. BackgroundViewController는 너무 범용적인 이름이 아닐까 우려되네요...
| searchController.searchBar.resignFirstResponder() | ||
| return true | ||
| } | ||
|
|
There was a problem hiding this comment.
delegate method를 사용하셨군요! 아주 좋습니다.
| @@ -8,7 +8,7 @@ | |||
| import UIKit | |||
| import SnapKit | |||
|
|
|||
| class SearchViewController: UIViewController { | |||
| class SearchViewController: BackgroundViewController { | |||
|
|
|||
There was a problem hiding this comment.
BackgroundViewController는 Search 탭 관련 뷰 컨트롤러들이 상속받을 클래스였군요. BackgroundViewController 보단 SearchBackgroundViewController 등이 좋지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.