feat: merge "Upload SDL" to "Build your template" and add "Plain Linux" template

[hiroyukikumazawa]

refs #227

[ygrishajev]

@hiroyukikumazawa Thanks a bunch for your contribution!

I left some comments. Some of them may be considered a refactoring so please do reply if you feel comfortable fulfilling those.

While testing I also spotted a couple of bugs.

1. it is only possible to upload an SDL if it's not set yet. E.g. if the builder tab was visited and thus SDL is defined or if it is already defined in a different way uploaded SDL has no effect
2. if input is cancelled and no SDL is uploaded the implemented handler still tries to process the event and throws

I recorded a video with these for you.

[ygrishajev]

For issue #227

@hiroyukikumazawa We usually add this into commits. E.g.

fix: remove 'Upload SDL' button in other templates

refs #227

[ygrishajev]

@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:

npm run lint -- --fix
npm run format

I'd suggest you enable that in your IDE, should ease the whole thing generally.

[hiroyukikumazawa]

@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:

npm run lint -- --fix
npm run format

I'd suggest you enable that in your IDE, should ease the whole thing generally.

So many files have been changed even though that I didn't change. @ygrishajev

[ygrishajev]

@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:

npm run lint -- --fix

npm run format

I'd suggest you enable that in your IDE, should ease the whole thing generally.

So many files have been changed even though that I didn't change. @ygrishajev

@hiroyukikumazawa That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually.

[hiroyukikumazawa]

That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually

There are a lot of these changes.

[ygrishajev]

That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

[hiroyukikumazawa]

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

Right, so I will commit the changes.
Are you ok?

[ygrishajev]

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

Right, so I will commit the changes.

Are you ok?

Yea, just make a separate commit for the review. I'll check if anything's off.

[hiroyukikumazawa]

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

Right, so I will commit the changes.
Are you ok?

Yea, just make a separate commit for the review. I'll check if anything's off.

Ok

[ygrishajev]

@hiroyukikumazawa That commit looks good to me. It's a lot of changes indeed but this has to be done anyway. Thanks for doing this. Let's see if others are aligned on leaving it in this pr.

[baktun14]

@anilmurty Do you want to release it like this?

[anilmurty]

If it's going on the main deploy page, then I think no. This task was to just merge the upload SDL into the "create your template" tile. The VM tile can be done separately

[hiroyukikumazawa]

so should we set this thread to resolved status.

[hiroyukikumazawa]

I have commented out the "Plain Linux" tile for now.

[ygrishajev]

@hiroyukikumazawa thanks for bearing with us! Added couple comments :)

[ygrishajev]

Added a couple more. Apologise if these are not ur changes, just let me know and resolve please

[baktun14]

We may have to comment out the "Plain Linux" tile for now. Otherwise LGTM 👍

[ygrishajev]

Please squash commits before merging. Would be nice if we could keep formatting separately though

[hiroyukikumazawa]

Please squash commits before merging. Would be nice if we could keep formatting separately though

done squash
please check again. @ygrishajev

[ygrishajev]

Please squash commits before merging. Would be nice if we could keep formatting separately though

done squash please check again. @ygrishajev

@hiroyukikumazawa lgtm! thanks again for ur contribution! good job 💪

[ygrishajev]

@hiroyukikumazawa for your future contributions pls try using rebase instead of merge. Let's keep it as is for now though :)

[hiroyukikumazawa]

@hiroyukikumazawa for your future contributions pls try using rebase instead of merge. Let's keep it as is for now though :)

done, please check again