Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using custom RPC node and chain ID #7

Closed
jtary opened this issue Jan 30, 2023 · 4 comments · Fixed by #87
Closed

Add support for using custom RPC node and chain ID #7

jtary opened this issue Jan 30, 2023 · 4 comments · Fixed by #87
Assignees
Labels

Comments

@jtary
Copy link
Contributor

jtary commented Jan 30, 2023

Currently the RPC node and chain ID are hard-coded into the build file. To enable safer testing, it would be ideal if these values could be picked up from the ENV and overridden in the UI.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Additionally, the meta files could used to get the data for the chain: (eg: https://github.com/ovrclk/net/blob/master/mainnet/meta.json)

@boz
Copy link

boz commented Feb 13, 2023

It's OK to do this after GA IMHO

@anilmurty anilmurty added post-ga and removed ga labels Feb 15, 2023
@anilmurty
Copy link
Contributor

moved to post-ga

@anilmurty
Copy link
Contributor

update, Mar 2nd: @jtary working on implmenting this in the UI under settings.

@anilmurty
Copy link
Contributor

@jtary - could you please create two issues (for the things we talked about in our weekly sync) and reference them here? Even PR references (if you closed them) are fine:

  • Found another bug where a new provider’s info doesn’t show up if the provider was spun up while the user session hasn’t been refreshed.
  • Also made code changes to the data model for the whole app so that data recoil data (that stores data between pages) refreshes more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants