Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make provider attributes available in bids #124

Closed
baktun14 opened this issue Sep 13, 2023 · 5 comments
Closed

Make provider attributes available in bids #124

baktun14 opened this issue Sep 13, 2023 · 5 comments
Assignees
Labels
P1 repo/akash-api repo/node Akash node repo issues repo/provider Akash provider-services repo issues

Comments

@baktun14
Copy link

baktun14 commented Sep 13, 2023

The scope of this is larger than just GPU attributes but GPU model is the biggest painpoint at this time.

When deploying for a GPU, the bid engine doesn't return the GPU model or vendor. This is crucial for users to know which provider to choose for which model, especially when deploying with a wildcard in the SDL.

Here's an example of a bid:

{
    "bid": {
        "bid_id": {
            "owner": "akash1...tkvk",
            "dseq": "12793097",
            "gseq": 1,
            "oseq": 1,
            "provider": "akash19p4t9d069nashxre9jg6j60cqlqkvtht6egpc9"
        },
        "state": "open",
        "price": {
            "denom": "uakt",
            "amount": "368.320765000000000000"
        },
        "created_at": "12793100"
    },
    "escrow_account": {
        "id": {
            "scope": "bid",
            "xid": "akash...tkvk/12793097/1/1/akash1...pc9"
        },
        "owner": "akash1...pc9",
        "state": "open",
        "balance": {
            "denom": "uakt",
            "amount": "5000000.000000000000000000"
        },
        "transferred": {
            "denom": "uakt",
            "amount": "0.000000000000000000"
        },
        "settled_at": "12793100",
        "depositor": "akash1...pc9",
        "funds": {
            "denom": "uakt",
            "amount": "0.000000000000000000"
        }
    }
}

Also, if the protobuf types are to change for the bids, I think it would be a great idea to also add the model/vendor chosen on the deployment or lease. Currently on the deployment, we can see the model/vendor requested, but not the one leased.

@troian troian self-assigned this Sep 13, 2023
@troian troian added repo/node Akash node repo issues repo/provider Akash provider-services repo issues repo/akash-api P1 labels Sep 13, 2023
@baktun14
Copy link
Author

Also, I think it would be a great idea to have something generic to handle other specs/attributes than GPUs, like the type of CPU offered or memory or disk etc etc. To not have to change the protobuf type later on. Something like an attribute array.

@anilmurty anilmurty changed the title GPU model and vendor not returned in bid Make GPU Model and Vendor Info available in bids Oct 17, 2023
@anilmurty anilmurty changed the title Make GPU Model and Vendor Info available in bids Make provider attributes available in bids Oct 17, 2023
@anilmurty
Copy link

Oct 17 sync: This will need a network upgrade

@brewsterdrinkwater
Copy link
Collaborator

Oct 24 sync:

  • attributes are bound to hardware.
  • Artur took into account future cases, so this is all included in the network upgrade.
  • Max wants to include provider attributes.
  • The only attributes available after the network upgrade is GPU. Other attributes will be there, but not used at this stage.
  • Future changes will not need an upgrade.
  • Artur is happy with the spec. Will be sharing later today.
  • Will be shared with clients ASAP.
  • Will sync with internal team for Network upgrade.

@brewsterdrinkwater
Copy link
Collaborator

oct 31st:

  • API part is done.
  • Network upgrade migration is implemented.
  • Going through testing right now. Testnetify tool needed to be updated for use in testing network upgrade.
  • Need to chat with Cloudmos guys on supporting client

@anilmurty
Copy link

Nov 7:

  • Finalized updates to the blockchain and verified that network upgrade works
  • Once the end-to-end tests and verified, will be able to cut a release
  • Mainnet upgrade is set for Nov 20th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 repo/akash-api repo/node Akash node repo issues repo/provider Akash provider-services repo issues
Projects
Status: Released (in Prod)
Development

No branches or pull requests

4 participants