Improvement: Response headers handled in a case sensitive way

[bcachet]

Hello,

In Request module, you parse headers (__responseHeaderCallback) in a case-sensitive way.
You do not enforce CURL to use HTTP 1.1 Headers in HTTP2.0 are lower case.
You can endup in not parsing the headers correctly.

protected function  __responseHeaderCallback(&$curl, &$data)
	{
		if (($strlen = strlen($data)) <= 2)
		{
			return $strlen;
		}

		if (substr($data, 0, 4) == 'HTTP')
		{
			$this->response->code = (int)substr($data, 9, 3);

			return $strlen;
		}

		list($header, $value) = explode(': ', trim($data), 2);

		switch (strtolower($header))
		{
			case 'last-modified':
				$this->response->setHeader('time', strtotime($value));
				break;

			case 'content-length':
				$this->response->setHeader('size', (int)$value);
				break;

			case 'content-type':
				$this->response->setHeader('type', $value);
				break;

			case 'etag':
				$this->response->setHeader('hash', $value{0} == '"' ? substr($value, 1, -1) : $value);
				break;

			default:
				if (preg_match('/^x-amz-meta-.*$/', $header))
				{
					$this->setHeader($header, is_numeric($value) ? (int)$value : $value);
				}
				break;
		}

		return $strlen;
	}

Hope it helps

[nikosdion]

Could you please make a Pull Request with your changes?

[bcachet]

Here it is: #4

[nikosdion]

PR gh-4 has been already merged. This issue wasn't closed because the PR didn't reference the issue (yep, you can only link issues to PRs manually). So I'm closing this issue as fixed.