Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enter/return does not always works #40

Closed
jixiuf opened this issue Nov 25, 2018 · 6 comments
Closed

enter/return does not always works #40

jixiuf opened this issue Nov 25, 2018 · 6 comments
Labels

Comments

@jixiuf
Copy link
Collaborator

jixiuf commented Nov 25, 2018

should similar to vim/vim#1998

in redis-cli or fzf enter/return behavior like Ctrl-j in iterm2

@akermu akermu added the bug label Nov 25, 2018
@QiangF
Copy link

QiangF commented Nov 25, 2018

I noticed that with the default setting for fzf, enter doesn't do accept like in xterm, so I have this setting:

export FZF_DEFAULT_OPTS="--extended --cycle --bind=\
ctrl-j:accept,ctrl-k:kill-line,tab:toggle-up,btab:toggle-down,\
ctrl-y:execute('echo {} | xclip -selection clipboard')+abort"

@akermu
Copy link
Owner

akermu commented Dec 11, 2018

This unfortunately this is currently unfixable, because emacs itself has the control over the tty descriptor and we cannot access it from the module.

One solution would be to do our own I/O like it was done before this commit or teach emacs to access the tty settings we need.

@QiangF
Copy link

QiangF commented Dec 14, 2018

We need this to be solved to user marker. https://github.com/pindexis/marker

@deb0ch
Copy link
Contributor

deb0ch commented Dec 21, 2018

@QiangF You just made me discover Marker and it looks great 😺

@QiangF
Copy link

QiangF commented Dec 22, 2018

@deb0ch You may also like ralph, I am trying to make maker and ralph work together.
https://github.com/qw3rtman/ralph

@mattiasb
Copy link

I noticed that with the default setting for fzf, enter doesn't do accept like in xterm, so I have this setting:

export FZF_DEFAULT_OPTS="--extended --cycle --bind=\
ctrl-j:accept,ctrl-k:kill-line,tab:toggle-up,btab:toggle-down,\
ctrl-y:execute('echo {} | xclip -selection clipboard')+abort"

For anyone else reading this, I belive all other settings above except --bind=ctrl-j:accept is noise and not needed to work around this specific issue. So add something like this to your environment and you should be good:

FZF_DEFAULT_OPTS=--bind=ctrl-j:accept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants