-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics on workers #34
Comments
Should we be storing this to redis, or just log it? |
Not sure yet. This is definitely more of a nice to have though. I was wondering if there's a coda hale metrics type library for erlang that can be configured to output to different sources. |
I think it would be enough to just expose the metric to callback somewhere and let the developer connect it to their prefered tool. For some people just want to log the data and some uses a full metric tool like datadog. |
We've recently implemented a simple middleware to export counts and timings from Exq to StatsD via ExStatsD in the same format as sidekiq pro metrics Would you be interested in a PR? It would add an optional dependency on the StatsD client package. |
@mbuhot I'd be interested to see your middleware, even if it doesn't get merged into exq :) |
@mbuhot Thanks! I was about to build this exact same thing, and this is exactly what I need. One small question: https://gist.github.com/mbuhot/93eab4472901eb18294d4eff1456aff6#file-exq_statsd_middleware-ex-L35 Thanks again! |
@LeeXGreen yes we also extracted the timing code out of the Logger middleware into its own middleware, which just populated the |
Various metrics on worker performance (perhaps broken out by worker type):
This can be implemented as middleware. See Sidekiq Metrics for example.
Consider using: https://github.com/pinterest/elixometer
The text was updated successfully, but these errors were encountered: