Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor as a Library #7

Closed
esodan opened this issue Dec 17, 2017 · 3 comments
Closed

Refactor as a Library #7

esodan opened this issue Dec 17, 2017 · 3 comments

Comments

@esodan
Copy link
Contributor

esodan commented Dec 17, 2017

I propose following directory/files structure:

ROOT
meson.build
src
All library VALA files
meson.build
demo
Window.vala
meson.build
data
meson.build
gtkcanvas.pc.in

No subdirectories in SRC and all files related to the library are there.

If you Agree, I'll continue a PR ASAP.
@Philip-Scott
Copy link
Member

Philip-Scott commented Dec 18, 2017 •
edited
Loading

The only thing i'm not sure i agree is with the no subdirectories in src but other than that, and as long as meson can also build docs, then that would be great!

Really appreciate the help! Thanks :)

@Alecaddd
Copy link
Member

This is awesome!
I agree with @Philip-Scott in maintaining the subdirectories in the src folder.

Is there any specific reason why you suggested to not have any subfolder?

@esodan
Copy link
Contributor Author

esodan commented Dec 18, 2017

Changes merged with subdirectories in src/

@esodan esodan closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alecaddd @esodan @Philip-Scott