docs: gradle config that works from quickstarts #1867
Conversation
| @@ -13,7 +13,7 @@ By default both client and server are generated and Java or Scala is autodetecte | |||
|
|
|||
| ### Installation | |||
|
|
|||
| Follow instructions at [Gradle plugin portal](https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle) to apply plugin. | |||
There was a problem hiding this comment.
Any clue of how we could update https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle, which now has incomplete instructions?
There was a problem hiding this comment.
Nope, I guess we'll have to check with @raboof if he still has access and can hand over account
There was a problem hiding this comment.
Hi! 👋 😄
I don't see a way to edit the instructions at https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle from the web UI, I suspect they will get updated automatically by changing the fields under pluginBundle in gradle-plugin/build.gradle.
Of course it would still be good to transfer ownership of this package to you. Looks like this can be done by opening an issue at https://github.com/gradle/plugin-portal-requests#transferring-ownership . Can you create an account to transfer ownership to?
There was a problem hiding this comment.
Heyhey, I've created an account johanandren. Please trigger the transfer thanks!
There was a problem hiding this comment.
| plugins { | ||
| id 'com.lightbend.akka.grpc.gradle' version '$project.version$' | ||
| } | ||
| } |
There was a problem hiding this comment.
Feels like we define the same things twice now. What is the recommend way to add plugins? settings or buildscript (or both)?
There was a problem hiding this comment.
I think I tried only one of them and it didn't work, but I may be wrong. Can check tomorrow.
There was a problem hiding this comment.
Dropping buldscript seems to work: akka/akka-grpc-quickstart-java.g8#64
There was a problem hiding this comment.
Single file seems nicer though, I'll try only buildscript and no settings.gradle as well
There was a problem hiding this comment.
Good, once we got it working it might be worth changing plugin-tester projects so that they look the same. There I think we need the local repo as well, since we are testing with a local publish.
There was a problem hiding this comment.
Updated the builds here, slightly simpler in some sense, but had to keep the gradle.settings to include local maven in repositories searched for plugins.
* docs: gradle config that works from quickstarts * Simplify plugin tester gradle setup
* docs: gradle config that works from quickstarts * Simplify plugin tester gradle setup
* docs: gradle config that works from quickstarts * Simplify plugin tester gradle setup
No description provided.